Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@zeeshanrafiqrana
Copy link
Contributor

@zeeshanrafiqrana zeeshanrafiqrana commented Dec 7, 2023

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@zeeshanrafiqrana zeeshanrafiqrana requested a review from a team as a code owner December 7, 2023 22:26
@zeeshanrafiqrana
Copy link
Contributor Author

@erikjohnston
Copy link
Member

(Sign off has been completed out-of-band)

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry, I've missed the fact that'll you need to:

  1. add a changelog file (as per the contributing guide); and
  2. add a brief description of the new option at https://github.com/matrix-org/synapse/blob/10ada2ff6d2a08108edf5b4dbe6562cc9465523d/docs/usage/configuration/config_documentation.md#sentry

Hopefully that should only take ten minutes.

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the wording a little bit to match our style, but they're only minor tweaks,

Thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants