Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Get CI to check PRs have been signed-off #16348

Merged
merged 3 commits into from
Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ concurrency:
cancel-in-progress: true

jobs:
check-signoff:
if: "github.event_name == 'pull_request'"
uses: "matrix-org/backend-meta/.github/workflows/sign-off.yml@v2"

# Job to detect what has changed so we don't run e.g. Rust checks on PRs that
# don't modify Rust code.
changes:
Expand Down Expand Up @@ -225,6 +229,7 @@ jobs:
- check-lockfile
- lint-clippy
- lint-rustfmt
- check-signoff
runs-on: ubuntu-latest
steps:
- run: "true"
Expand Down Expand Up @@ -627,9 +632,10 @@ jobs:
with:
needs: ${{ toJSON(needs) }}

# The newsfile lint may be skipped on non PR builds
# The newsfile and signoff lints may be skipped on non PR builds
# Cargo test is skipped if there is no changes on Rust code
skippable: |
check-signoff
lint-newsfile
cargo-test
cargo-bench
1 change: 1 addition & 0 deletions changelog.d/16348.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Get CI to check PRs have been signed-off.
Loading