Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Set thread_id column to non-null for event_push_{actions,actions_staging,summary} #15597

Merged
merged 11 commits into from
May 26, 2023
Merged

Set thread_id column to non-null for event_push_{actions,actions_staging,summary} #15597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
719ec6d
Set thread_id column to non-null for event_push_{actions,actions_stag…
clokep Mar 30, 2023
88c7514
Move DROP INDEX to after ALTER .. SET NOT NULL
reivilibre Mar 31, 2023
99c3de5
Use constraints instead of indexes.
clokep Apr 14, 2023
51feacf
Move schema deltas.
clokep May 2, 2023
0be2974
Run constraint validation in the background.
clokep May 2, 2023
ad4201c
Separate delta by table to avoid deadlocks.
clokep May 15, 2023
f108f17
Drop the indexes in the background.
clokep May 15, 2023
8667c3c
Newsfragment
clokep May 15, 2023
69ffef6
Merge remote-tracking branch 'origin/develop' into clokep/threads-cle…
clokep May 24, 2023
5ba223c
Rename schema deltas.
clokep May 24, 2023
0a1d15a
Order the bg updates.
clokep May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename schema deltas.
  • Loading branch information
@clokep
clokep committed May 24, 2023
commit 5ba223cb202355fff995300e4fb48667d8e15b0c
0 ...ta/76/04thread_notifications_backfill.sql → ...ta/77/05thread_notifications_backfill.sql
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...5thread_notifications_not_null.sql.sqlite → ...6thread_notifications_not_null.sql.sqlite
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ CREATE UNIQUE INDEX event_push_summary_unique_index2 ON event_push_summary (user
-- Recreate some indexes in the background, by re-running the background updates
-- from 72/02event_push_actions_index.sql and 72/06thread_notifications.sql.
INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
(7403, 'event_push_summary_unique_index2', '{}')
(7706, 'event_push_summary_unique_index2', '{}')
ON CONFLICT (update_name) DO UPDATE SET progress_json = '{}';
INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
(7403, 'event_push_actions_stream_highlight_index', '{}')
(7706, 'event_push_actions_stream_highlight_index', '{}')
ON CONFLICT (update_name) DO UPDATE SET progress_json = '{}';
2 changes: 1 addition & 1 deletion ..._not_null_event_push_actions.sql.postgres → ..._not_null_event_push_actions.sql.postgres
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ ALTER TABLE event_push_actions
-- We then validate the constraint which doesn't need to worry about new data. It
-- only needs a SHARE UPDATE EXCLUSIVE lock but can still take a while to complete.
INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
(7605, 'event_push_actions_thread_id', '{}');
(7706, 'event_push_actions_thread_id', '{}');
2 changes: 1 addition & 1 deletion ...l_event_push_actions_staging.sql.postgres → ...l_event_push_actions_staging.sql.postgres
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ ALTER TABLE event_push_actions_staging
-- We then validate the constraint which doesn't need to worry about new data. It
-- only needs a SHARE UPDATE EXCLUSIVE lock but can still take a while to complete.
INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
(7605, 'event_push_actions_staging_thread_id', '{}');
(7706, 'event_push_actions_staging_thread_id', '{}');
4 changes: 2 additions & 2 deletions ..._not_null_event_push_summary.sql.postgres → ..._not_null_event_push_summary.sql.postgres
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ ALTER TABLE event_push_summary
-- We then validate the constraint which doesn't need to worry about new data. It
-- only needs a SHARE UPDATE EXCLUSIVE lock but can still take a while to complete.
INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
(7605, 'event_push_summary_thread_id', '{}'),
(7706, 'event_push_summary_thread_id', '{}'),
-- Also clean-up the old indexes.
(7605, 'event_push_drop_null_thread_id_indexes', '{}');;
(7706, 'event_push_drop_null_thread_id_indexes', '{}');;