Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add release note and update doc regarding ICU #14712

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Add release note and update doc regarding ICU #14712

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d68e8d5
Add release note and update doc regarding ICU
Dec 20, 2022
12ec11c
Apply suggestions from code review
Dec 20, 2022
6f26b16
comments + explicit dep in Dockerfile
Dec 20, 2022
70c9ecb
Apply suggestions from code review
Dec 20, 2022
82e341c
suggestions
Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: reivilibre <oliverw@matrix.org>
  • Loading branch information
@reivilibre
2 people authored and Sean Quah committed Dec 20, 2022
commit 12ec11c78901ec611c05d12b4e4e10181d883b8a
2 changes: 1 addition & 1 deletion docs/setup/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ xcode-select --install
Some extra dependencies may be needed, you can use Homebrew (https://brew.sh) for that.
MatMaul marked this conversation as resolved.
Show resolved Hide resolved

You may need to install icu, and make the icu binaries and libraries accessible.
Please follow [official instructions](https://pypi.org/project/PyICU/) of PyICU to do so.
Please follow [the official instructions of PyICU](https://pypi.org/project/PyICU/) to do so.

On ARM-based Macs you may also need to install libjpeg and libpq:
```sh
Expand Down
4 changes: 2 additions & 2 deletions docs/upgrade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ This version introduces optional support for an [improved user search dealing wi

To do so it uses the ICU library through PyICU.
If you want to take advantage of this feature you need to install PyICU
MatMaul marked this conversation as resolved.
Show resolved Hide resolved
but also ICU native dependency and its development headers
so that PyICU can build since no prebuild wheels is available.
but also the ICU native dependency and its development headers
so that PyICU can build since no prebuilt wheels are available.
You can follow [PyICU documentation](https://pypi.org/project/PyICU/) to do so.
MatMaul marked this conversation as resolved.
Show resolved Hide resolved

MatMaul marked this conversation as resolved.
Show resolved Hide resolved
# Upgrading to v1.73.0
Expand Down