Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Handle half-created indices in receipts index background update #14650

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Handle half-created indices in receipts index background update #14650

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17c43d1
Factor out index creation method from `register_background_index_update`
Dec 9, 2022
5e14dcb
Handle half-created indices in receipts index background update
Dec 9, 2022
55723ab
Add newsfile
Dec 9, 2022
5cc4729
fixup: remove dead code (thanks dmr!)
Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions synapse/storage/databases/main/receipts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,9 +999,12 @@ def _remote_duplicate_receipts_txn(txn: LoggingTransaction) -> None:
_remote_duplicate_receipts_txn,
)

await self._create_receipts_index(
"receipts_linearized_unique_index",
"receipts_linearized",
await self.db_pool.updates.create_index_in_background(
index_name="receipts_linearized_unique_index",
table="receipts_linearized",
columns=["room_id", "receipt_type", "user_id"],
where_clause="thread_id IS NULL",
unique=True,
)

await self.db_pool.updates._end_background_update(
Expand Down Expand Up @@ -1050,9 +1053,12 @@ def _remote_duplicate_receipts_txn(txn: LoggingTransaction) -> None:
_remote_duplicate_receipts_txn,
)

await self._create_receipts_index(
"receipts_graph_unique_index",
"receipts_graph",
Comment on lines -1053 to -1055
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is _create_receipts_index now dead code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks.

await self.db_pool.updates.create_index_in_background(
index_name="receipts_graph_unique_index",
table="receipts_graph",
columns=["room_id", "receipt_type", "user_id"],
where_clause="thread_id IS NULL",
unique=True,
)

await self.db_pool.updates._end_background_update(
Expand Down