Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Bump redis from 6-bullseye to 7-bullseye in /docker #13981

Closed
wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 30, 2022

Bumps redis from 6-bullseye to 7-bullseye.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps redis from 6-bullseye to 7-bullseye.

---
updated-dependencies:
- dependency-name: redis
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner September 30, 2022 13:29
@dependabot dependabot bot added dependencies Pull requests from dependabot that update a dependency file docker Pull requests that update Docker code labels Sep 30, 2022
@DMRobertson
Copy link
Contributor

Gonna do the close-reopen dance to test the changelog thing yet again.

@dependabot close

@dependabot dependabot bot closed this Oct 3, 2022
@dependabot dependabot bot deleted the dependabot/docker/docker/redis-7-bullseye branch October 3, 2022 17:01
@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 3, 2022

@dependabot reopen

@dependabot dependabot bot reopened this Oct 3, 2022
@dependabot dependabot bot restored the dependabot/docker/docker/redis-7-bullseye branch October 3, 2022 17:02
@DMRobertson
Copy link
Contributor

CI is green. We should sanity check there are no breaking changes in Redis 7.

@clokep
Copy link
Member

clokep commented Oct 4, 2022

We should sanity check there are no breaking changes in Redis 7.

Don't we want to test against the oldest supported version though?

@DMRobertson
Copy link
Contributor

We should sanity check there are no breaking changes in Redis 7.

Don't we want to test against the oldest supported version though?

Yes. I'm not sure if that's the purpose of this dockerfile though?

There's a specific olddeps test job, but that only handles old python dependencies and interpreters. It doesn't handle old sqlite/postgres/rust/etc AFAICS. Maybe more thought is needed?

@richvdh
Copy link
Member

richvdh commented Oct 6, 2022

There's a specific olddeps test job, but that only handles old python dependencies and interpreters. It doesn't handle old sqlite/postgres/rust/etc AFAICS. Maybe more thought is needed?

The intention was that olddeps would handle old sqlite (though in practice it can be hard to align oldest-supported-python with oldest-supported-sqlite without building our own python). But also: olddeps only exists for trial, not complement.

It feels like we need to build both "old-deps" and "new-deps" images to test with complement, but that means adding even more load to the CI workers.

In the meantime... having this image use "oldest supported redis" sounds like the best way. And we can tell dependabot to shut up about it.

@richvdh
Copy link
Member

richvdh commented Oct 11, 2022

@dependabot ignore this dependency

@richvdh richvdh closed this Oct 11, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 11, 2022

OK, I won't notify you about redis again, unless you re-open this PR. 😢

@dependabot dependabot bot deleted the dependabot/docker/docker/redis-7-bullseye branch October 11, 2022 13:33
@realtyem realtyem mentioned this pull request Oct 21, 2022
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests from dependabot that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants