Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Scratch changes to fix have_seen_event not being invalidated #13861

Closed
wants to merge 3 commits into from
Closed

Scratch changes to fix have_seen_event not being invalidated #13861

wants to merge 3 commits into from

Commits on Sep 21, 2022

  1. Scratch changes for fix have_seen_event not being invalidated 

    See #13856
    @MadLittleMods
    MadLittleMods committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    a732796 View commit details
    Browse the repository at this point in the history

  2. Fix have_seen_event cache not being invalidated when we persist the e… 

    …vent

Fix for
#13856

Fixed by calling `_invalidate_caches_for_event`
when we persist an event.

And an additional fix in `_invalidate_caches_for_event`
to make sure it uses the correct cache key. This seems
like it would be an easy foot-gun for any `tree=True`
cache.

Wrong:
```py
self.have_seen_event.invalidate((room_id, event_id))
```

Correct:
```py
self.have_seen_event.invalidate(((room_id, event_id),))
```
    @MadLittleMods
    MadLittleMods committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    dd4be24 View commit details
    Browse the repository at this point in the history

  3. Move cache invalidation to the main thread 

    See #13861 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    24905b7 View commit details
    Browse the repository at this point in the history