This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
A third batch of Pydantic validation for rest/client/account.py #13736
Merged
Commits on Sep 7, 2022
-
Use consistent capitalisation of
Threepid
David Robertson committedSep 7, 2022 Configuration menu - View commit details
-
Copy full SHA for f39bfc5 - Browse repository at this point
Copy the full SHA f39bfc5View commit details -
Pull out ClientSecretType for upcoming reuse
David Robertson committedSep 7, 2022 Configuration menu - View commit details
-
Copy full SHA for b854c09 - Browse repository at this point
Copy the full SHA b854c09View commit details -
PostBody for /account/3pid/add
David Robertson committedSep 7, 2022 Configuration menu - View commit details
-
Copy full SHA for cdeb0a3 - Browse repository at this point
Copy the full SHA cdeb0a3View commit details -
PostBody for /account/3pid/bind
David Robertson committedSep 7, 2022 Configuration menu - View commit details
-
Copy full SHA for 92f7f01 - Browse repository at this point
Copy the full SHA 92f7f01View commit details -
This one looks a bit magic, so I've added some extra tests for sanity's sake.
David Robertson committedSep 7, 2022 Configuration menu - View commit details
-
Copy full SHA for e584fa0 - Browse repository at this point
Copy the full SHA e584fa0View commit details -
PostBody for /account/3pid/unbind
David Robertson committedSep 7, 2022 Configuration menu - View commit details
-
Copy full SHA for 76d615e - Browse repository at this point
Copy the full SHA 76d615eView commit details -
PostBody for /account/3pid/delete
David Robertson committedSep 7, 2022 Configuration menu - View commit details
-
Copy full SHA for 3defe6f - Browse repository at this point
Copy the full SHA 3defe6fView commit details -
David Robertson committed
Sep 7, 2022 Configuration menu - View commit details
-
Copy full SHA for 35d664a - Browse repository at this point
Copy the full SHA 35d664aView commit details
Commits on Sep 8, 2022
-
Fix min length of
client_secret
David Robertson committedSep 8, 2022 Configuration menu - View commit details
-
Copy full SHA for 8143310 - Browse repository at this point
Copy the full SHA 8143310View commit details
Commits on Sep 15, 2022
-
Opt for simpler
Literal[...]
typeI would like to see a StrEnum but I am somewhat anxious of making that change right now. I think we should get validation in place first and then look at propagating better types into the application.
David Robertson committedSep 15, 2022 Configuration menu - View commit details
-
Copy full SHA for 38ae8c7 - Browse repository at this point
Copy the full SHA 38ae8c7View commit details -
ClientSecretType -> ClientSecretStr
David Robertson committedSep 15, 2022 Configuration menu - View commit details
-
Copy full SHA for a840e8c - Browse repository at this point
Copy the full SHA a840e8cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.