Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update get_pdu to return the original, pristine EventBase #13320

Merged
merged 22 commits into from
Jul 20, 2022
Merged

Update get_pdu to return the original, pristine EventBase #13320

merged 22 commits into from
Jul 20, 2022

Commits on Jul 18, 2022

  1. Update get_pdu to return original, pristine EventBase 

    Split out from #13205

As discussed at:

 - #13205 (comment)
 - #13205 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    ee236ca View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @MadLittleMods
    MadLittleMods committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    79a1b72 View commit details
    Browse the repository at this point in the history

  3. Internal change, no specific bugfix

    @MadLittleMods
    MadLittleMods committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    bfd35fd View commit details
    Browse the repository at this point in the history

  4. Explain why not

    @MadLittleMods
    MadLittleMods committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    e0e20a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Add tests

    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    22410f2 View commit details
    Browse the repository at this point in the history

  2. Some more clarity

    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    09c411b View commit details
    Browse the repository at this point in the history

  3. Re-use room ID

    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    6029b42 View commit details
    Browse the repository at this point in the history

  4. Better still actionable no-fluff assertion message 

    See #13320 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    09167b1 View commit details
    Browse the repository at this point in the history

  5. Describe why we use a cache here 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @MadLittleMods @richvdh
    MadLittleMods and richvdh authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    eb6a291 View commit details
    Browse the repository at this point in the history

  6. Remove direct access to internal property 

    We'd like to stop doing this altogether in the future.

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @MadLittleMods @richvdh
    MadLittleMods and richvdh authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    1c4e57c View commit details
    Browse the repository at this point in the history

  7. Make it obvious that we're pulling and using a different cache 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @MadLittleMods @richvdh
    MadLittleMods and richvdh authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    488f5ed View commit details
    Browse the repository at this point in the history

  8. Remove assumption/speculation 

    See #13320 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    29a5269 View commit details
    Browse the repository at this point in the history

  9. Default is already no metadata 

    See #13320 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    2688e44 View commit details
    Browse the repository at this point in the history

  10. Refactor structure to avoid duplicating the event copy logic 

    See:

 - #13320 (comment)
 - #13320 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    24913e7 View commit details
    Browse the repository at this point in the history

  11. Pluralization typo 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @MadLittleMods @richvdh
    MadLittleMods and richvdh authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    0e6dd5a View commit details
    Browse the repository at this point in the history

  12. Explain that we return a copy that is safe to modify 

    See #13320 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    5bc75ed View commit details
    Browse the repository at this point in the history

  13. Fix lints

    @MadLittleMods
    MadLittleMods committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    dea7669 View commit details
    Browse the repository at this point in the history

  14. Fix description typo

    @MadLittleMods
    MadLittleMods authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    72e65a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Share event throughout 

    See #13320 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    86fe0dc View commit details
    Browse the repository at this point in the history

  2. Different comment 

    See #13320 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    fd879bb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'madlittlemods/pristine-get_pdu' of github.com:matrix-or… 

    …g/synapse into madlittlemods/pristine-get_pdu
    @MadLittleMods
    MadLittleMods committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    354678f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into madlittlemods/pristine-get_pdu 

    Conflicts:
	tests/federation/test_federation_client.py
    @MadLittleMods
    MadLittleMods committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    233077c View commit details
    Browse the repository at this point in the history