This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Replace pyjwt with authlib in org.matrix.login.jwt
#13011
Merged
DMRobertson
merged 15 commits into
matrix-org:develop
from
aytchell:aytchell/replace_pyjwt_with_authlib
Jun 15, 2022
Merged
Replace pyjwt with authlib in org.matrix.login.jwt
#13011
DMRobertson
merged 15 commits into
matrix-org:develop
from
aytchell:aytchell/replace_pyjwt_with_authlib
Jun 15, 2022
Commits on Jun 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 074cdf7 - Browse repository at this point
Copy the full SHA 074cdf7View commit details -
Due to the move from PyJWT to authlib the error messages have changed. Instead of mapping messages in the code just to please the tests I changed the expücted error messages in the unit tests.
Configuration menu - View commit details
-
Copy full SHA for 338ae35 - Browse repository at this point
Copy the full SHA 338ae35View commit details -
Added a helper script to create JWTs for development
Seems like PyJWT provides a script to create JWTs from the command line. Authlib does not provide such a script so I added this tiny script as a replacement. It doesn't parse parameters nor writes files but since this feature is only required by developer while doing some local tests I'd say that's OK.
Configuration menu - View commit details
-
Copy full SHA for 13bccbb - Browse repository at this point
Copy the full SHA 13bccbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3891e0a - Browse repository at this point
Copy the full SHA 3891e0aView commit details -
Signed-off-by: Hannes Lerchl <hannes.lerchl@googlemail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a7e7b0 - Browse repository at this point
Copy the full SHA 5a7e7b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 629ef41 - Browse repository at this point
Copy the full SHA 629ef41View commit details
Commits on Jun 10, 2022
-
Moved import statements for authlib
In case a server hoster doesn't use oidc or jwt there should be no need to install authlib. So for such cases the imports need to 'come later'.
Configuration menu - View commit details
-
Copy full SHA for 8e78b79 - Browse repository at this point
Copy the full SHA 8e78b79View commit details
Commits on Jun 11, 2022
-
Removed pyjwt frm pyproject.toml
Updated poetry.lock file with --no-update Signed-off-by: Hannes Lerchl <hannes.lerchl@googlemail.com>
Configuration menu - View commit details
-
Copy full SHA for b4e56a1 - Browse repository at this point
Copy the full SHA b4e56a1View commit details
Commits on Jun 14, 2022
-
Applied changes from review findings
Review performed by DMRobertson Signed-off-by: Hannes Lerchl <hannes.lerchl@googlemail.com>
Configuration menu - View commit details
-
Copy full SHA for a650138 - Browse repository at this point
Copy the full SHA a650138View commit details -
Configuration menu - View commit details
-
Copy full SHA for 470dc0b - Browse repository at this point
Copy the full SHA 470dc0bView commit details
Commits on Jun 15, 2022
-
Re-added a check for installed dependencies
The pyjwt based version of the jwt login flow contained a check (like this) for PyJWT. Since authlib is an optional dependency I add this check when `jwt_config` is configured.
Configuration menu - View commit details
-
Copy full SHA for 382d02f - Browse repository at this point
Copy the full SHA 382d02fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aa6a11 - Browse repository at this point
Copy the full SHA 8aa6a11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 395997e - Browse repository at this point
Copy the full SHA 395997eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81c525c - Browse repository at this point
Copy the full SHA 81c525cView commit details -
Merge remote-tracking branch 'origin/develop' into aytchell/replace_p…
…yjwt_with_authlib
David Robertson committedJun 15, 2022 Configuration menu - View commit details
-
Copy full SHA for 0039fe7 - Browse repository at this point
Copy the full SHA 0039fe7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.