Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Tidy up and type-hint the database engine modules #12734

Merged
merged 10 commits into from
May 16, 2022
Merged

Tidy up and type-hint the database engine modules #12734

merged 10 commits into from
May 16, 2022

Commits on May 13, 2022

  1. BaseDatabaseEngine: use ConnectionType generic

    David Robertson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    e36410c View commit details
    Browse the repository at this point in the history

  2. Let the DatabaseEngines provide their db module 

    I think this is all a bit weird, and it feels like a home-grown version
of sqlalchemy core. I am not very pleased with the conditional import of psycopg2!
    David Robertson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    e9dcff7 View commit details
    Browse the repository at this point in the history

  3. Don't propgate DB config upwards 

    It's completely unused
    David Robertson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    c8f1458 View commit details
    Browse the repository at this point in the history

  4. Stub out the DB2API module

    David Robertson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    7cf1719 View commit details
    Browse the repository at this point in the history

  5. Let's disallow untyped defs while I'm at it

    David Robertson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    467b2a0 View commit details
    Browse the repository at this point in the history

  6. Changelog

    David Robertson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    44af3e4 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Revert "Don't propgate DB config upwards" 

    This reverts commit c8f1458.
    David Robertson committed May 16, 2022
    Configuration menu
    Copy the full SHA
    4d8b840 View commit details
    Browse the repository at this point in the history

  2. Describe the DBAPI2 exception heirarchy

    David Robertson committed May 16, 2022
    Configuration menu
    Copy the full SHA
    6dcbf99 View commit details
    Browse the repository at this point in the history

  3. Tweak writing (thanks Sean) 

    Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
    @squahtx
    David Robertson and squahtx authored May 16, 2022
    Configuration menu
    Copy the full SHA
    24d9189 View commit details
    Browse the repository at this point in the history

  4. Fix weird indent??

    David Robertson committed May 16, 2022
    Configuration menu
    Copy the full SHA
    27e90f0 View commit details
    Browse the repository at this point in the history