Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix a bug introduced in Synapse v1.50.0rc1 whereby outbound federation could fail because too many EDUs were produced for device updates. #11730

Merged
merged 17 commits into from
Jan 13, 2022
Merged

Fix a bug introduced in Synapse v1.50.0rc1 whereby outbound federation could fail because too many EDUs were produced for device updates. #11730

merged 17 commits into from
Jan 13, 2022

Commits on Jan 13, 2022

  1. Clarify docstring

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    e3665f4 View commit details
    Browse the repository at this point in the history

  2. Add a few HL-style invariant comments to help reason about how long c… 

    …ollections are
    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    9f54d0f View commit details
    Browse the repository at this point in the history

  3. Extend docstring for _get_device_update_edus_by_remote

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    ad8da37 View commit details
    Browse the repository at this point in the history

  4. Comment about _get_device_update_edus_by_remote length guarantee

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    d17de19 View commit details
    Browse the repository at this point in the history

  5. Add types for _get_device_updates_by_remote_txn and amend docstring

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    a306a89 View commit details
    Browse the repository at this point in the history

  6. Create variables for if conditions

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    cc8904e View commit details
    Browse the repository at this point in the history

  7. Use extracted variable in if conditions

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    2cf1691 View commit details
    Browse the repository at this point in the history

  8. Calculate the remaining length budget

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    aceb240 View commit details
    Browse the repository at this point in the history

  9. Check for 2 free slots before adding a cross-signing key update

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    451b4ff View commit details
    Browse the repository at this point in the history

  10. Add FIXME note that this complication can be removed when we cut out … 

    …the backwards compatibility
    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    34ae0ba View commit details
    Browse the repository at this point in the history

  11. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    62e8e45 View commit details
    Browse the repository at this point in the history

  12. Add a test to ensure cross-signing key updates don't blow the limit

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    2107d12 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review 

    Co-authored-by: David Robertson <davidr@element.io>
    @reivilibre
    reivilibre and David Robertson authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    6643b94 View commit details
    Browse the repository at this point in the history

  14. Use JsonDict type for EDUs

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    8b01179 View commit details
    Browse the repository at this point in the history

  15. Commentsmithing

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    b5dc363 View commit details
    Browse the repository at this point in the history

  16. Check there are no more updates left after the end of the test

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    0476aee View commit details
    Browse the repository at this point in the history

  17. Add FIXME note about discarding OpenTracing contexts

    @reivilibre
    reivilibre committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    57b3601 View commit details
    Browse the repository at this point in the history