Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve docstrings for methods related to sending EDUs to application services #11138

Merged
merged 16 commits into from
Oct 21, 2021
Merged

Improve docstrings for methods related to sending EDUs to application services #11138

merged 16 commits into from
Oct 21, 2021

Commits on Oct 20, 2021

  1. Add docstring to on_new_event

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    795d058 View commit details
    Browse the repository at this point in the history

  2. Add docstring to _notify_app_services_ephemeral

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    1e5a0f2 View commit details
    Browse the repository at this point in the history

  3. Add comments to notify_interested_services_ephemeral

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    2fd99fe View commit details
    Browse the repository at this point in the history

  4. Add comments to _handle* methods and those methods they call

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    0ce33e5 View commit details
    Browse the repository at this point in the history

  5. Improve docstring for format_user_presence_state

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    e423a94 View commit details
    Browse the repository at this point in the history

  6. newsfile

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    1df714c View commit details
    Browse the repository at this point in the history

  7. Note that AS interest via room ID or alias isn't respected 

    Typing and read receipt events (those that are associated with a room)
should be sent to an AS that has registered interest in that room,
according to MSC2409:

https://github.com/Sorunome/matrix-doc/blob/231084da132af6518ecefa2a42c37937dfe373d2/proposals/2409-appservice-edus.md#expectations-of-when-an-edu-should-be-pushed-to-an-appservice
    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    95a4972 View commit details
    Browse the repository at this point in the history

  8. Clean up some comments, add a new TODO...

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    97b9d24 View commit details
    Browse the repository at this point in the history

  9. Remove unused 'service' argument from PresenceSource.get_new_events

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    4c1f9d2 View commit details
    Browse the repository at this point in the history

  10. +1 confidence

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    b7988c5 View commit details
    Browse the repository at this point in the history

  11. Remove tail end of currently_active description

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    cd8ac02 View commit details
    Browse the repository at this point in the history

  12. lint

    @anoadragon453
    anoadragon453 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    d22faf8 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Update synapse/handlers/appservice.py 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @anoadragon453 @clokep
    anoadragon453 and clokep authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    4c206d4 View commit details
    Browse the repository at this point in the history

  2. Move TODO to issue #11150

    @anoadragon453
    anoadragon453 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    d337164 View commit details
    Browse the repository at this point in the history

  3. Replace TODO with solution in PR #11140

    @anoadragon453
    anoadragon453 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    4623514 View commit details
    Browse the repository at this point in the history

  4. Replace TODO with issue #11152

    @anoadragon453
    anoadragon453 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    768382e View commit details
    Browse the repository at this point in the history