Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Rename /batch_send query parameter from ?prev_event to more obvious usage with ?prev_event_id (MSC2716) #10839

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Rename /batch_send query parameter from ?prev_event to more obvious usage with ?prev_event_id (MSC2716) #10839

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e38026f
Rename from ?prev_event to more obvious usage with ?prev_event_id
MadLittleMods Sep 17, 2021
73a3c5e
Add changelog
MadLittleMods Sep 17, 2021
8300964
Fix lint
MadLittleMods Sep 17, 2021
12d1527
Merge branch 'develop' into madlittlemods/2716-rename-prev_event-to-p…
MadLittleMods Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
@MadLittleMods
MadLittleMods committed Sep 17, 2021
commit 8300964ed48667af2f96963210d730cd47cf1f57
4 changes: 3 additions & 1 deletion synapse/rest/client/room_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ async def on_POST(
assert_params_in_dict(body, ["state_events_at_start", "events"])

assert request.args is not None
prev_event_ids_from_query = parse_strings_from_args(request.args, "prev_event_id")
prev_event_ids_from_query = parse_strings_from_args(
request.args, "prev_event_id"
)
chunk_id_from_query = parse_string(request, "chunk_id")

if prev_event_ids_from_query is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse_strings_from_args has a required param to make this easy for you, but 🤷

Expand Down