Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Cleanup opentracing logging for syncs #10828

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Cleanup opentracing logging for syncs #10828

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01154bb
Cleanup opentracing logging for syncs
erikjohnston Sep 15, 2021
6f3d5a5
Newsfile
erikjohnston Sep 15, 2021
dbf5bff
Use emtpy tuple
erikjohnston Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use emtpy tuple
  • Loading branch information
@erikjohnston
erikjohnston committed Sep 15, 2021
commit dbf5bff126574a91f72f80ddd0c84caa05fcffe6
2 changes: 1 addition & 1 deletion synapse/handlers/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1960,7 +1960,7 @@ async def _generate_room_entry(

with start_active_span("generate_room_entry"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change the span name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with it, but open to other suggestions 🤷

set_tag("room_id", room_id)
log_kv({"events": len(events or [])})
log_kv({"events": len(events or ())})

log_kv(
{
Expand Down