This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Start adding store-and-forward direct-to-device messaging #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class SendToDeviceRestServlet(servlet.RestServlet): | ||
| PATTERNS = client_v2_patterns( | ||
| "/sendToDevice/(?P<message_type>[^/]*)/(?P<txn_id>[^/]*)$", |
There was a problem hiding this comment.
We use underscores fore APIs?
There was a problem hiding this comment.
camelcased:
/_matrix/client/r0/createRoom
/_matrix/client/r0/initialSync
/_matrix/client/r0/publicRooms
/_matrix/client/r0/voip/turnServer
^/_matrix/client/r0/rooms/[^/]*/initialSync$
underscores:
^/_matrix/client/r0/profile/[^/]*/avatar_url$
^/_matrix/client/r0/user/[^/]*/account_data/[^/]*$
lowercase:
^/_matrix/client/r0/pushrules/
^/_matrix/client/r0/profile/[^/]*/displayname$
There was a problem hiding this comment.
I retract my previous statement, and replace it with: your style isn't inconsistent enough.
|
LGTM. Tests look like you need to merge in from develop. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the local part of direct-to-device messaging intended for exchanging end-to-end keys and other device-to-device signalling.