Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Usage of Python 2 __metaclass__ #7932

@auscompgeek

Description

@auscompgeek

There are 7 instances of __metaclass__ in Synapse, which does nothing in Python 3.
These should probably be changed to use class Foo(metaclass=abc.ABCMeta).

synapse/handlers/room_member.py
48:    __metaclass__ = abc.ABCMeta

synapse/server.py
141:    __metaclass__ = abc.ABCMeta

synapse/replication/http/_base.py
77:    __metaclass__ = abc.ABCMeta

synapse/storage/data_stores/main/account_data.py
41:    __metaclass__ = abc.ABCMeta

synapse/storage/data_stores/main/receipts.py
41:    __metaclass__ = abc.ABCMeta

synapse/storage/data_stores/main/push_rule.py
80:    __metaclass__ = abc.ABCMeta

synapse/storage/data_stores/main/stream.py
251:    __metaclass__ = abc.ABCMeta

Metadata

Metadata

Assignees

No one assigned

    Labels

    Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contributionz-p3(Deprecated Label)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions