ERROR: Invalid value for encryption_enabled_by_default_for_room_type

[rodolpheh]

Description

When updating from 1.16.0 to 1.16.1, I stumbled upon an issue where my server wouldn't restart. The logs displays the following error :

ERROR: Invalid value for encryption_enabled_by_default_for_room_type

I previously set up encryption_enabled_by_default to off in my homeserver.yaml. Since it should be off by default, I just commented the line and the server started without any issue.

Steps to reproduce

• set the parameter encryption_enabled_by_default_for_room_type to off in your homeserver.yaml
• recreate the container
• watch the logs

Version information

• Homeserver:

If not matrix.org: lunai.re

• Version: 1.16.1

• Install method: docker

• Platform: docker container in an Arch Linux set up

[babolivier]

Hey @rodolpheh, and thanks for your report!

It looks like we weren't aware, when implementing this feature, that PyYAML (the parser we use for the configuration file) translates the string "off" into the boolean value False if it's unquoted. This seems to be a liberal interpretation of the YAML spec.

The right fix for Synapse here is to also check for whether the parsed value for encryption_enabled_by_default_for_room_type is False.

[babolivier]

Will be fixed in #7822