rest/media: Don't log Requested file is too large

[jo-so]

Description

The error and warning messages about to large resources aren't useful. They should get dropped.

2019-07-14 14:41:52,063 - synapse.http.matrixfederationclient - 874 - WARNING - GET-212- {GET-O-24} [matrix.org] Error reading response: 502: Requested file is too large > 10485760 bytes
2019-07-14 14:41:52,064 - synapse.rest.media.v1.media_repository - 390 - ERROR - GET-212- Failed to fetch remote media matrix.org/GPMcaQOeYjjWNTMFarGJfQBJ
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/synapse/rest/media/v1/media_repository.py", line 373, in _download_remote_file
    "allow_remote": "false",
synapse.api.errors.SynapseError: 502: Requested file is too large > 10485760 bytes

Proposed patch: 0001-rest-media-Don-t-log-Requested-file-is-too-large.patch.txt

Version information

• Version: 1.0.0-2
• Install method: apt install matrix-synapse
• Platform: Debian/stable

[richvdh]

Thanks for reporting these. Please be aware that we can't accept patches without sign-off. Please could you follow our contributing procedure?

[jo-so]

Richard van der Hoff hat am So 14. Jul, 10:52 (-0700) geschrieben:

Thanks for reporting these. Please be aware that we can't accept patches without sign-off. Please could you follow our [contributing procedure](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#how-to-contribute)?

The patch is only a proposal. If it's not what you like, go on and hack your own. It's totally fine. My only hope this issue gets addressed.

…

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #5683 (comment)

[richvdh]

I'm going to close this as we can't use it in its current format.