Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Ratelimit config code has a RateLimitConfig class and a RatelimitConfig one #4983

Closed
#13442
Closed
Ratelimit config code has a RateLimitConfig class and a RatelimitConfig one#4983
#13442
Labels
P3(OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patchesS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contributiongood first issueGood for newcomers
@babolivier

Description

@babolivier
babolivier
opened on Apr 1, 2019

This makes the config code harder to read/understand due to both classes being super easy to mistake for the other. One (probably RateLimitConfig) should be renamed into something else.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3(OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patchesS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contributiongood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions