Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

backfilling missing events when receiving a federation txn blocks all other txns for that room #1729

Open
ara4n opened this issue Dec 30, 2016 · 4 comments
Open

backfilling missing events when receiving a federation txn blocks all other txns for that room #1729

ara4n opened this issue Dec 30, 2016 · 4 comments
Labels
A-Federation A-Performance Performance, both client-facing and admin-facing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@ara4n
Copy link
Member

ara4n commented Dec 30, 2016

so if my hs sends an event to another hs, and it causes that hs to backfill an event over federation from elsewhere, all other events to that hs for that room will block until the backfill completes. this feels wrong
@ara4n ara4n mentioned this issue Dec 30, 2016
Closed
@ara4n
Copy link
Member Author

ara4n commented Dec 31, 2016 •
edited
Loading

this appears to be the 'linearizer lock'. can we shrink its granularity or otherwise get rid of it?

This was referenced Dec 31, 2016
Closed
Closed
Merged
Closed
@ara4n
Copy link
Member Author

ara4n commented Jan 5, 2017

it's particularly perverse that if get_missing_events fails, we go get a state snapshot instead... having relinquished the lock. :(

@ara4n ara4n added federation-meltdown z-p2 (Deprecated Label) labels Jan 5, 2017
@MadLittleMods MadLittleMods added the A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) label Aug 24, 2022
@MadLittleMods
Copy link
Contributor

Related to #13619

@MadLittleMods MadLittleMods added A-Federation and removed A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) labels Aug 25, 2022
@MadLittleMods
Copy link
Contributor

MadLittleMods commented Aug 25, 2022 •
edited
Loading

It seems like this is talking about on_receive_pdu and the _room_pdu_linearizer with homeservers pushing events to us. Not backfill in terms of /messages.

@DMRobertson DMRobertson added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Occasional Affects or can be seen by some users regularly or most users rarely A-Performance A-Performance Performance, both client-facing and admin-facing and removed z-p2 (Deprecated Label) z-federation-meltdown labels Aug 25, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federation A-Performance Performance, both client-facing and admin-facing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadLittleMods @ara4n @DMRobertson