This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
limit total timeout for get_missing_events to 10s #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be worth noting in the comment that this disables HTTP client retries entirely. Also worth noting in the comment that this increases the chances of falling back to fetching state, which curiously isn't guarded by the same lock as the get_missing_events. Also might be worth mentioning in the comment that we don't want to block for a long time because we are holding a lock on the room that could block other transactions that needed to fetch missing events. Other than lack of comments LGTM. |
|
will fix #1741 when merged |
|
@NegativeMjark have updated the comment - PTAL |
|
LGTM |
NegativeMjark
added a commit
that referenced
this pull request
Jan 5, 2017
…vents cherrypick #1744: limit total timeout for get_missing_events to 10s
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeout calls to get_missing_events from the federation client after 10s rather than the current 5 minutes. should improve the workaround for #1733 and #1729 some more.