Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Unconfigurable harsh ratelimiting for leaving rooms #16006

@gabrc52

Description

@gabrc52

Description

Clients (at least Element) have an option to leave a space and leave all rooms in it.

image

If you choose to leave all rooms, the client will make leave requests for every room you are on.

If you are on many rooms, this will take a long time, to the point it seems like it hangs. Looking at the network tab in the developer tools shows a lot of 429 Too Many Requests responses.

In conclusion, the defualt ratelimiting for leaving rooms is too harsh. It doesn't seem like it can be overriden either:

https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html has mention of rc_joins but there is no rc_leaves

Steps to reproduce

  • join a space on Element on a homeserver using the default rate limits
  • join many rooms
  • leave the space, choosing to leave all rooms

Homeserver

matrix.mit.edu

Synapse Version

{"server_version":"1.88.0","python_version":"3.10.6"}

Installation Method

Debian packages from packages.matrix.org

Database

PostgreSQL

Workers

Single process

Platform

Ubuntu 22.04.2, PowerEdge R710

Configuration

No response

Relevant log output

N/A

Anything else that would be useful to know?

No response

Metadata

Metadata

Assignees

Labels

A-ConfigConfiguration, or the documentation thereofA-LeaveLeaving a roomO-OccasionalAffects or can be seen by some users regularly or most users rarelyS-MinorBlocks non-critical functionality, workarounds exist.T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions