Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

E-mail pushers are not created during registration when non-interactive SSO registration (localpart_template) is used #15904

Open
c-cal opened this issue Jul 10, 2023 · 0 comments
Labels
A-Email-Push Email notifications A-User-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@c-cal
Copy link

c-cal commented Jul 10, 2023

Description

synapse/handlers/register.py#L1008 need token to add email pusher.

But synapse/handlers/register.py#L392 doesn't provide any.

Steps to reproduce

  • add enable_notifs: true and notif_for_new_users: true config
  • configure Synapse to accept SSO login
  • provide SSO template for non-interactive registration (ie: localpart_template)
  • provide SSO template for email
  • login with a SSO account that provide some email attribute, according to prev config
  • see that email notif are not enable => email pusher was not created at registration

Homeserver

matrix.org

Synapse Version

1.87

Installation Method

Docker (matrixdotorg/synapse)

Database

Workers

Single process

Platform

Configuration

No response

Relevant log output

-

Anything else that would be useful to know?

The creation of email pushers should not rely on a token when registering, there is no need to track devices for them (see #15890)

@reivilibre reivilibre changed the title add email pusher during non-interactive SSO registration E-mail pushers are not created during registration when non-interactive SSO registration (localpart_template) is used Jul 21, 2023
@reivilibre reivilibre added S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. A-Email-Push Email notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-User-Experience labels Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Email-Push Email notifications A-User-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants