Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-mail pushers are not created during registration when non-interactive SSO registration (localpart_template) is used #15904

Open
matrixbot opened this issue Dec 21, 2023 · 1 comment

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023

This issue has been migrated from #15904.


Description

synapse/handlers/register.py#L1008 need token to add email pusher.

But synapse/handlers/register.py#L392 doesn't provide any.

Steps to reproduce

  • add enable_notifs: true and notif_for_new_users: true config
  • configure Synapse to accept SSO login
  • provide SSO template for non-interactive registration (ie: localpart_template)
  • provide SSO template for email
  • login with a SSO account that provide some email attribute, according to prev config
  • see that email notif are not enable => email pusher was not created at registration

Homeserver

matrix.org

Synapse Version

1.87

Installation Method

Docker (matrixdotorg/synapse)

Database

Workers

Single process

Platform

Configuration

No response

Relevant log output

-

Anything else that would be useful to know?

The creation of email pushers should not rely on a token when registering, there is no need to track devices for them (see matrix-org/synapse#15890)

@matrixbot matrixbot changed the title Dummy issue E-mail pushers are not created during registration when non-interactive SSO registration (localpart_template) is used Dec 22, 2023
@matrixbot matrixbot reopened this Dec 22, 2023
@svartoyg
Copy link

I stumbled upon that too recently and was told, that most likely this will not be fixed for thet classic setup. However, the problem seems to be gone, when using the MAS setup. Kudos @ Ricardo, for trying out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants