Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add timestamp massaging to /createRoom #15346

Open
1 task done
MadLittleMods opened this issue Mar 29, 2023 · 0 comments
Open
1 task done

Add timestamp massaging to /createRoom #15346

MadLittleMods opened this issue Mar 29, 2023 · 0 comments
Labels
A-Create-Room A-Testing Issues related to testing in complement, synapse, etc O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Mar 29, 2023

As propsed by MSC3997, following in the footsteps of MSC3316's timestamp massaging query parameter for /send?ts=123, add the same thing to the /createRoom endpoint

POST /_matrix/client/v3/createRoom?ts=123

Why

When writing end-to-end tests, it's useful to have your room appear as though it was created back in time before your messages were sent and to have stable/consistent timestamps. If you start using the timestamp massaging with messages, it can appear as though those events occurred before the m.room.create and other primordial events.

So this issue, proposes being able to modify the origin_server_ts of all of the primordial room creation events.

This could also apply to other endpoints (/join, /ban) but I'm mostly concerned with the /createRoom endpoint because that's the hairy area in my Matrix Public Archive tests at the moment. And /ban, etc can be emulated with the normal /send endpoint and sending the appropriate events.

/join can only be emulated for local joins as joins against rooms the server doesn't know about doesn't work since there is no way to specify via servers`. Created MSC3998

Todo

@squahtx squahtx added S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. A-Create-Room O-Occasional Affects or can be seen by some users regularly or most users rarely O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Testing Issues related to testing in complement, synapse, etc and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Create-Room A-Testing Issues related to testing in complement, synapse, etc O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants