-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Declare support for Matrix 1.6 #15089
Comments
I've attempted to add some notes about what I think is done, but likely could use double checking. See #14486 for a previous iteration. |
…upported on a homeserver (#10398) Add stable unstable version (`org.matrix.msc3030.stable`) for jump to date [before `v1.6` is fully supported on a homeserver](matrix-org/synapse#15089). Related to element-hq/element-web#24362 but does not solve immediately because Synapse does not supply `org.matrix.msc3030.stable` yet Also refactored `ServerSupportUnstableFeatureController` to support multiple feature groups where any one of them will enable the setting. All features in a feature group are required. This way having either `org.matrix.msc3030` or `org.matrix.msc3030.stable` will enable the jump to date feature flag with a config of `[["org.matrix.msc3030"], ["org.matrix.msc3030.stable"]]`
…ported on Synapse Related to #15089 Element Web PR to honor `org.matrix.msc3030.stable`: matrix-org/matrix-react-sdk#10398
…upported on a homeserver (#10398) Add stable unstable version (`org.matrix.msc3030.stable`) for jump to date [before `v1.6` is fully supported on a homeserver](matrix-org/synapse#15089). Related to element-hq/element-web#24362 but does not solve immediately because Synapse does not supply `org.matrix.msc3030.stable` yet Also refactored `ServerSupportUnstableFeatureController` to support multiple feature groups where any one of them will enable the setting. All features in a feature group are required. This way having either `org.matrix.msc3030` or `org.matrix.msc3030.stable` will enable the jump to date feature flag with a config of `[["org.matrix.msc3030"], ["org.matrix.msc3030.stable"]]`
The legacy. method ( |
#15317 ended up using this for appservices, will need to split this into three tasks. I think. |
Up until #14525, which landed in v1.74.0rc1, Synapse sent the key ID when requesting keys. MSC3938 notes that this is a breaking change. Making it such that the key ID / trailing slash is invalid means that Synapse < 1.74.0 will be unable to request keys from Synapse >= 1.xx (whenever this lands). This seems pretty awful, @richvdh did you have any thoughts on how we were hoping to roll this out? I'm not getting a good feel of how much this would break if we just did it now. |
Yeah, it's probably premature to rip out support. I think my intention here was that servers that support only spec v1.6 do not need to allow the trailing slash (and of course, they should not include the trailing slash, or the key ID, in outgoing requests), but servers that want to maintain support for earlier versions of the spec still need to permit it. My suggestion would be to continue to permit key ID or trailing slash, but log a warning. Strictly speaking that makes Synapse non-spec-compliant for v1.6, but I think it's the best we can do for now. |
That seems reasonable. Looking back, we maybe should have revved the endpoint version. 🤷 |
See https://matrix.org/blog/2023/02/14/matrix-v-1-6-release
Client-Server API
/timestamp_to_event
endpoint to stable v1 location #14471Server-Server API
Application Service API
Identity Service API
Push Gateway API
Room Versions
The text was updated successfully, but these errors were encountered: