Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove type parameter from /thumbnail endpoint #14913

Closed
clokep opened this issue Jan 25, 2023 · 1 comment · Fixed by #15137
Closed

Remove type parameter from /thumbnail endpoint #14913

clokep opened this issue Jan 25, 2023 · 1 comment · Fixed by #15137
Assignees
@clokep
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Jan 25, 2023

This is unspecced and per matrix-org/matrix-spec#1414 we should use the Accept header instead.
@clokep clokep added the A-Spec-Compliance places where synapse does not conform to the spec label Jan 25, 2023
@clokep clokep mentioned this issue Jan 25, 2023
Closed
@clokep
Copy link
Member Author

clokep commented Jan 25, 2023

There's not a single request to matrix.org using this parameter. I think we can just rip it out.

@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 25, 2023
@clokep clokep self-assigned this Feb 22, 2023
@clokep clokep mentioned this issue Feb 22, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop parsing the unspecced type parameter on thumbnail requests. matrix-org/synapse
1 participant
@clokep