Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type parameter on /thumbnail endpoint #1414

Closed
clokep opened this issue Jan 25, 2023 · 2 comments
Closed

Missing type parameter on /thumbnail endpoint #1414

clokep opened this issue Jan 25, 2023 · 2 comments
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@clokep
Copy link
Member

clokep commented Jan 25, 2023

Link to problem area: https://spec.matrix.org/v1.5/client-server-api/#get_matrixmediav3thumbnailservernamemediaid

Issue
Synapse supports a type parameter (which defaults to image/png if not provided), this is not in the spec, but has existed since this endpoint has.

matrix-media-repo does not seem to support this.

Dendrite does not seem to support this either, although declares it uses a similar algorithm to Synapse to find thumbnails.

Expected behaviour
Add the type parameter, as documented above.

As an aside, @Half-Shot rightly pointed out that this is what Accept headers are for?

@clokep clokep added the spec-bug Something which is in the spec, but is wrong label Jan 25, 2023
@turt2live
Copy link
Member

This is indeed what Accept headers are for. Given this feature has not proved useful in practice, it feels best described as a Synapse Feature rather than as Spec Omission - closing accordingly (an MSC can be opened to add it).

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2023
@clokep
Copy link
Member Author

clokep commented Jan 25, 2023

Thanks for the clarification. I've filed matrix-org/synapse#14913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

No branches or pull requests

2 participants