Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

"404 row not found" when changing the display name of a AS ghost (SYN-572) #1461

Closed
matrixbot opened this issue Jan 4, 2016 · 6 comments
Closed
Labels
A-Application-Service Related to AS support O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@matrixbot
Copy link
Member

https://github.com/matrix-org/sytest/tree/markjh/ghost_displaynames/tests/60app-services/04displayname.pl

Steps:
AS doesn't register a ghost user
AS creates a room as a ghost user.
AS tries to change the display name of the ghost user.

HTTP/1.1 404 Not Found
Date: Mon, 04 Jan 2016 17:03:01 GMT
Server: Synapse/0.12.0 (b=develop,t=v0.12.0,f35f8d0)
 
{"errcode":"M_UNKNOWN","error":"No row found"}

(Imported from https://matrix.org/jira/browse/SYN-572)

(Reported by @NegativeMjark)

@matrixbot
Copy link
Member Author

Jira watchers: @NegativeMjark

@matrixbot matrixbot added z-p2 (Deprecated Label) z-bug (Deprecated Label) labels Nov 7, 2016
@matrixbot matrixbot changed the title "404 row not found" when changing the display name of a AS ghost (SYN-572) "404 row not found" when changing the display name of a AS ghost (https://github.com/matrix-org/synapse/issues/1461) Nov 7, 2016
@matrixbot matrixbot changed the title "404 row not found" when changing the display name of a AS ghost (https://github.com/matrix-org/synapse/issues/1461) "404 row not found" when changing the display name of a AS ghost (SYN-572) Nov 7, 2016
AndrewJDR added a commit to matrix-hacks/matrix-puppet-bridge that referenced this issue Jan 3, 2017
keyvan was seeing retry loops under certain situations.
The loop seems to occur on the setDisplayName call,
so perhaps we need to call join before that.
Seems related to:
matrix-org/synapse#1461
@richvdh
Copy link
Member

richvdh commented Aug 1, 2022

keywords: /profile

@richvdh richvdh added P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. and removed z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Aug 1, 2022
@DMRobertson
Copy link
Contributor

What is a "ghost user"?

@DMRobertson DMRobertson added X-Needs-Info This issue is blocked awaiting information from the reporter A-Application-Service Related to AS support O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches labels Oct 19, 2022
@richvdh
Copy link
Member

richvdh commented Oct 20, 2022

@Half-Shot this sounds like an AS term: any ideas?

@DMRobertson
Copy link
Contributor

I would guess from this bit of perl
that "ghost" is oldspeak for "user in an application service's namespace". (User created with POST /v3/register with type "m.login.application_service" in the request body.)

@DMRobertson
Copy link
Contributor

I tried to get the test linked in the description to run/fail again but ended up fighting sytest.

less /tmp/logs/results.tap 
  #** Use of uninitialized value $req in concatenation (.) or string at /sytest/run-tests.pl line 751.
  # $req = 
  #** Use of uninitialized value $req in exists at /sytest/run-tests.pl line 761.
  #** Use of uninitialized value $req in concatenation (.) or string at /sytest/run-tests.pl line 762.
  ok 1 AS-ghosted users can set their display name # skip lack of 
  1..1

AFAICS that means the test wasn't ran at all.

Given that we have a very similar-sounding test here which isn't in the test blacklist, I'm going to assume there's no problem here and move on.

@DMRobertson DMRobertson closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Application-Service Related to AS support O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants