Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove failover_on_unknown_endpoint from /timestamp_to_event after 2023-11-16 #14577

Open
MadLittleMods opened this issue Nov 28, 2022 · 0 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Nov 28, 2022

Spawning from #14471 (comment) as mentioned by @squahtx,

We can safely remove the following code that was introduced in #14471 when stabilizing the MSC3030 /timestamp_to_event endpoint:

# Since this endpoint is new, we should try other servers before giving up.
# We can safely remove this in a year (remove after 2023-11-16).
failover_on_unknown_endpoint=True,

After a year, the endpoint will no longer be new and there will be many Synapse versions that include the stabilized endpoint.

It's possible that we leave this check in place though. Maybe we want to handle the case where another homeserver implementation doesn't have it available.

@MadLittleMods MadLittleMods added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Nov 28, 2022
@MadLittleMods MadLittleMods added this to the Revisit: Next Year milestone Nov 28, 2022
@MadLittleMods MadLittleMods added the Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases label Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases
Projects
None yet
Development

No branches or pull requests

1 participant