Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Wheels in CI: Failing to set up Rust does not fail the "Running before_all" task #14136

Open
babolivier opened this issue Oct 11, 2022 · 0 comments
Open

Wheels in CI: Failing to set up Rust does not fail the "Running before_all" task #14136

babolivier opened this issue Oct 11, 2022 · 0 comments
Labels
A-CI Issues related to CI on the Synapse repository O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@babolivier
Copy link
Contributor

See https://github.com/matrix-org/synapse/actions/runs/3226703547/jobs/5280558136

In this case, curl https://sh.rustup.rs/ -sSf | sh -s -- --default-toolchain stable -y failed because of a connectivity issue. However, since foo | bar succeeds if foo fails but bar succeeds, this isn't caught as a failure and the "Running before_all" tasks fails, leading to a more confusing error when building the wheels.

@DMRobertson says:

before-all = "bash -c 'set -o pipefail; curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y'" Might work? But is pretty write-only
@babolivier babolivier added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow A-CI Issues related to CI on the Synapse repository labels Oct 11, 2022
@MadLittleMods MadLittleMods changed the title Wheels in CI: Failing to set up Rust doesnot fail the "Running before_all" task Wheels in CI: Failing to set up Rust does not fail the "Running before_all" task May 25, 2023
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-CI Issues related to CI on the Synapse repository O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@babolivier