Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheels in CI: Failing to set up Rust does not fail the "Running before_all" task #14136

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023

This issue has been migrated from #14136.


See https://github.com/matrix-org/synapse/actions/runs/3226703547/jobs/5280558136

In this case, curl https://sh.rustup.rs/ -sSf | sh -s -- --default-toolchain stable -y failed because of a connectivity issue. However, since foo | bar succeeds if foo fails but bar succeeds, this isn't caught as a failure and the "Running before_all" tasks fails, leading to a more confusing error when building the wheels.

@DMRobertson says:

before-all = "bash -c 'set -o pipefail; curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y'" Might work? But is pretty write-only

@matrixbot matrixbot changed the title Dummy issue Wheels in CI: Failing to set up Rust does not fail the "Running before_all" task Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant