Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Consider only inserting events we actually want to purge into events_to_purge #13419

Open
babolivier opened this issue Jul 29, 2022 · 0 comments
Labels
A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. Z-Cleanup Things we want to get rid of, but aren't actively causing pain

Comments

@babolivier
Copy link
Contributor

babolivier commented Jul 29, 2022

In purge_history we create a temporary table (events_to_purge, which we drop at the end of the purge) to store events we want to purge, alongside with whether or not we should delete them. It feels like there's room for improvement there, as in theory we should be able to only insert events we want to purge. I'm not sure how complicated this would be in practice, though. According to the code, we seem to use all the events in events_to_purge, even those not slated for deletion, to figure out state groups to remove. However according to comments it also seems to think that all events in that table are slated for deletion.

@erikjohnston erikjohnston added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Aug 1, 2022
@MadLittleMods MadLittleMods added Z-Cleanup Things we want to get rid of, but aren't actively causing pain A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db labels Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. Z-Cleanup Things we want to get rid of, but aren't actively causing pain
Projects
None yet
Development

No branches or pull requests

3 participants