Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider only inserting events we actually want to purge into events_to_purge #13419

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023

This issue has been migrated from #13419.


In purge_history we create a temporary table (events_to_purge, which we drop at the end of the purge) to store events we want to purge, alongside with whether or not we should delete them. It feels like there's room for improvement there, as in theory we should be able to only insert events we want to purge. I'm not sure how complicated this would be in practice, though. According to the code, we seem to use all the events in events_to_purge, even those not slated for deletion, to figure out state groups to remove. However according to comments it also seems to think that all events in that table are slated for deletion.

@matrixbot matrixbot changed the title Dummy issue Consider only inserting events we actually want to purge into events_to_purge Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant