This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
get_room_version
doesn't use the cache #11706
Closed
Description
we have two functions for getting the version of a room from the database, get_room_version_id
and get_room_version
. The former gets the raw string, and then caches it to speed up future lookups. The second looks up the raw string, and then consults the list of known room versions to decode it into a RoomVersion
object. The problem is that it doesn't cache the result, so is generally slower than it should be.
If get_room_version
needs to exist at all, it should probably just wrap get_room_version_id
.