Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

get_room_version doesn't use the cache #11706

Closed
@richvdh

Description

@richvdh

we have two functions for getting the version of a room from the database, get_room_version_id and get_room_version. The former gets the raw string, and then caches it to speed up future lookups. The second looks up the raw string, and then consults the list of known room versions to decode it into a RoomVersion object. The problem is that it doesn't cache the result, so is generally slower than it should be.

If get_room_version needs to exist at all, it should probably just wrap get_room_version_id.

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-TolerableMinor significance, cosmetic issues, low or no impact to users.T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.good first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions