Do not error if the content-length is not provided.

matrix-org · Dec 2, 2020 · c07d383 · c07d383
1 parent c5b6abd
commit c07d383
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/8862.bugfix b/changelog.d/8862.bugfix
@@ -0,0 +1 @@
+Fix a longstanding bug if the `Content-Length` header was not provided to the upload media resource.
diff --git a/synapse/rest/media/v1/upload_resource.py b/synapse/rest/media/v1/upload_resource.py
@@ -44,7 +44,7 @@ async def _async_render_POST(self, request):
         requester = await self.auth.get_user_by_req(request)
         # TODO: The checks here are a bit late. The content will have
         # already been uploaded to a tmp file at this point
-        content_length = request.getHeader(b"Content-Length").decode("ascii")
+        content_length = request.getHeader("Content-Length")
         if content_length is None:
             raise SynapseError(msg="Request must specify a Content-Length", code=400)
         if int(content_length) > self.max_upload_size: