Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 92014fb

Browse files
author
David Robertson
authored
Don't build wheels for Python 3.7 (#15917)
* Don't build wheels for CPython or PyPy 3.7 * Update pyproject.toml comments * Manually update the changelog
1 parent 4ccfa16 commit 92014fb

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

CHANGES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ See [the upgrade notes](https://github.com/matrix-org/synapse/blob/release-v1.88
2424
### Deprecations and Removals
2525

2626
- **Remove deprecated `worker_replication_host`, `worker_replication_http_port` and `worker_replication_http_tls` configuration options.** See the [upgrade notes](https://github.com/matrix-org/synapse/blob/release-v1.88/docs/upgrade.md#removal-of-worker_replication_-settings) for more details. ([\#15860](https://github.com/matrix-org/synapse/issues/15860))
27-
- Remove support for Python 3.7 and hence for Debian Buster. ([\#15851](https://github.com/matrix-org/synapse/issues/15851), [\#15892](https://github.com/matrix-org/synapse/issues/15892), [\#15893](https://github.com/matrix-org/synapse/issues/15893))
27+
- Remove support for Python 3.7 and hence for Debian Buster. ([\#15851](https://github.com/matrix-org/synapse/issues/15851), [\#15892](https://github.com/matrix-org/synapse/issues/15892), [\#15893](https://github.com/matrix-org/synapse/issues/15893), [\#15917](https://github.com/matrix-org/synapse/pull/15917))
2828

2929
### Internal Changes
3030

pyproject.toml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,15 @@ build-backend = "poetry.core.masonry.api"
373373

374374
[tool.cibuildwheel]
375375
# Skip unsupported platforms (by us or by Rust).
376-
skip = "cp36* *-musllinux_i686 pp*aarch64 *-musllinux_aarch64"
376+
# See https://cibuildwheel.readthedocs.io/en/stable/options/#build-skip for the list of build targets.
377+
# We skip:
378+
# - CPython 3.6 and 3.7: EOLed
379+
# - PyPy 3.7: we only support Python 3.8+
380+
# - musllinux i686: excluded to reduce number of wheels we build.
381+
# c.f. https://github.com/matrix-org/synapse/pull/12595#discussion_r963107677
382+
# - PyPy on Aarch64 and musllinux on aarch64: too slow to build.
383+
# c.f. https://github.com/matrix-org/synapse/pull/14259
384+
skip = "cp36* cp37* pp37* *-musllinux_i686 pp*aarch64 *-musllinux_aarch64"
377385

378386
# We need a rust compiler
379387
before-all = "curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y --profile minimal"

0 commit comments

Comments
 (0)