Correctly handle hidden=True

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
matrix-org · Jul 19, 2021 · 59763c4 · 59763c4
1 parent 1dcccd3
commit 59763c4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/synapse/handlers/receipts.py b/synapse/handlers/receipts.py
@@ -187,9 +187,10 @@ def filter_out_hidden(events: List[JsonDict], user_id: str) -> List[JsonDict]:
                     hidden = user_rr.get("hidden", False)
                     if not hidden or rr_user_id == user_id:
                         new_users[rr_user_id] = user_rr.copy()
-                        if hidden:
+                        # If hidden has a value replace hidden with the correct prefixed key
+                        if user_rr.get("hidden", None) is not None:
                             new_users[rr_user_id].pop("hidden")
-                            new_users[rr_user_id]["org.matrix.msc2285.hidden"] = True
+                            new_users[rr_user_id]["org.matrix.msc2285.hidden"] = hidden
 
                 # Set new users unless empty
                 if len(new_users.keys()) > 0: