Fix FCM second retry sends #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the first attempt succeeds for all but one pushkey the second attempt will end up populating both the `to` and `registration_ids` fields, which is rejected by FCM (400).
clokep
suggested changes
Mar 17, 2023
| @@ -371,10 +371,13 @@ async def _dispatch_notification_unlimited( | |||
| body["priority"] = "normal" if n.prio == "low" else "high" | |||
|
|
|||
| for retry_number in range(0, MAX_TRIES): | |||
| # Should only ever be one of `to` or `registration_ids` fields | |||
There was a problem hiding this comment.
Would it be clearer to rebuild the body at the top of this loop?
Any chance of being able to test this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first attempt succeeds for all but one pushkey the second attempt will end up populating both the
toandregistration_idsfields, which is rejected by FCM (400). For context, full errors looked like: