Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TTL support for FCM notifications #312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add TTL support for FCM notifications #312

wants to merge 1 commit into from

Conversation

Fizzadar
Copy link

@Fizzadar Fizzadar commented Jul 5, 2022

No description provided.

@Fizzadar Fizzadar requested a review from a team as a code owner July 5, 2022 10:04
@squahtx
Copy link
Contributor

squahtx commented Jul 5, 2022

Notification fields seem to be defined in the spec. We might need a proposal to add a ttl field?

squahtx
squahtx reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Notification dict is specced and it's impolite for us to add extra fields to it.

I think we're allowed to put pusher-specific fields in device.data, so that could be an option?

@squahtx squahtx added the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squahtx squahtx squahtx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fizzadar @squahtx