allow loading poetry path #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+37
to
+41
| load-poetry-path: | ||
| description: > | ||
| Set to "true" to add the path to the poetry executable to the PATH. | ||
| required: false | ||
| default: "false" |
There was a problem hiding this comment.
Why not default to true as a sane default?
There was a problem hiding this comment.
Mostly wanted to avoid changing the action default behaviour. WDYT?
There was a problem hiding this comment.
Feels like nothing would change for existing consumers of the action if we default to true.
Comment on lines
+120
to
+123
| - name: Load poetry path | ||
| run: | | ||
| echo "$(poetry env info -p)/bin" >> "${GITHUB_PATH}" | ||
| if: "${{ inputs.load-poetry-path == 'true' }}" |
There was a problem hiding this comment.
As an alternative, what about just using poetry run xxx?
There was a problem hiding this comment.
This also works, but third-party scripts might expect the "binary" name to be available without having to go through poetry. (typically the case when installing ansible for example)
There was a problem hiding this comment.
Is that an actual use case yet? Link?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to call commands installed through poetry without going through
python -m <module>..This is used extensively in ESS-Helm repo.