Skip to content

Conversation

@jaywink
Copy link
Member

@jaywink jaywink commented Feb 5, 2021

Log different statuses based on the error we
had with the request and a success ok for
successful verifications.

  • errors logged in the actual checks phase
  • success logged at the end if successful
  • made some of the generic logger calles module logger calls

Log different statuses based on the error we
had with the request and a success ok for
successful verifications.
@jaywink jaywink requested a review from michaelkaye February 5, 2021 13:25
Copy link
Contributor

@michaelkaye michaelkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output looks cool by me

@jaywink jaywink merged commit e10a48e into master Feb 5, 2021
@jaywink jaywink deleted the jaywink/better-logging branch February 5, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants