Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all static image file formats with avif ones #2545

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MTRNord
Copy link
Collaborator

@MTRNord MTRNord commented Oct 29, 2024

More file size optimizations:

grafik

It seems to have good coverage according to https://caniuse.com/avif I think.

Copy link

cloudflare-workers-and-pages bot commented Oct 29, 2024

Deploying matrix-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9f40021
Status:🚫  Build failed.

View logs

@MTRNord
Copy link
Collaborator Author

MTRNord commented Oct 29, 2024

At least on my firefox fedora there seems to be also a significant/noticeable improvement in loadingtimes of the images. However in lighthouse/google pagespeed there seems to be no measurable difference in speed.

@MTRNord
Copy link
Collaborator Author

MTRNord commented Oct 29, 2024

I asked for some feedback and will update this comment as it comes in:

works alright on my desktop (macOS, Firefox | Chrome)

https://matrix.to/#/!kOXQjUbOfdYNCtRmZv:matrix.org/$gd-SYQCh5r8WXG23XYEVmbpxo1udqzYOFx8h_QyIlxg?via=matrix.org&via=element.io&via=mozilla.org

Fine in Vivaldi 6.9 and Firefox 132.0 on Android 12.0.14.

https://matrix.to/#/!kOXQjUbOfdYNCtRmZv:matrix.org/$ztl6YsIVSHhj-DkV0DJi1OFjFcNbYpkcvirKOO7GdyY?via=matrix.org&via=element.io&via=mozilla.org

@HarHarLinks
Copy link
Contributor

Works on my phone

@MTRNord
Copy link
Collaborator Author

MTRNord commented Nov 4, 2024

Turns out this is blocked by support on the opengraph consumers. See https://joost.blog/use-avif-webp-share-images/

My suggestion is to use https://www.getzola.org/documentation/content/image-processing/ to reencode PNGs at build time for opengraph to work. That should be best of both worlds and allows us a smaller repo size. Especially in combination with #2547

@MTRNord
Copy link
Collaborator Author

MTRNord commented Nov 7, 2024

So we have an oopengraph fix now but thats blocked by getzola/zola#1347 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants