Add test for joining a new federated room #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
added
the
T-Task
MadLittleMods
commented
Jun 29, 2022
MadLittleMods
commented
Jun 29, 2022
MadLittleMods
commented
Jul 5, 2022
MadLittleMods
commented
Jul 5, 2022
MadLittleMods
commented
Jul 7, 2022
MadLittleMods
commented
Aug 29, 2022
…patible with browser vs Node.js See #31 (comment)
…of the last message All of the messages were at the same time, so the homeserver, just returned the first one but in reality, it's a series of messages that happen one after the other so it should return the last one. We adjust the timestamps so they actually appear as a series. Although we think about changing the sort on the date tiebreak when looking backwards in Synapse.
MadLittleMods
deleted the
madlittlemods/test-for-join-new-federated-room
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for joining a new federated room and making sure the messages are available (homeserver should backfill).
Synapse changes: matrix-org/synapse#13205, matrix-org/synapse#13320
Dev notes