Support resolving OpenID tokens against any given homeserver #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For handling S2S discovery and fetching OpenID userinfo.
If multiple homeserver support enabled, we'll check whatever matrix server name that the token is indicated to be from.
turt2live
approved these changes
Jan 19, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Looks like nodejs and seems to do vaguely the right thing
jaywink
added a commit
to matrix-org/prosody-mod-auth-matrix-user-verification
that referenced
this pull request
Jan 19, 2021
If the matrix context in the passed in JWT contains a `server_name`, pass it on to UVS in the verify call. Requires matrix-org/matrix-user-verification-service#5
…given Matrix server name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows optionally to run in a multiple homeservers mode in where the given OpenID token will be checked against a given homeserver.
Room memberships are still only checked against the configured homeserver since that happens over Synapse admin API.
Closes #3