Skip to content

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Dec 31, 2021

Fixes #133

Alternative to #134.

@babolivier babolivier linked an issue Jan 20, 2022 that may be closed by this pull request
@reivilibre reivilibre marked this pull request as ready for review February 23, 2022 12:06
@reivilibre reivilibre requested a review from a team as a code owner February 23, 2022 12:06
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. I think it would make sense to include the tests in this PR.

I guess it isn't doable to use the same class directly? Since the class itself doesn't know how it is registered?

@reivilibre
Copy link
Contributor Author

I guess it isn't doable to use the same class directly?

I did this originally, but got told to do it this way. I think this way is cleaner even if just because the callbacks need their signatures massaging through the wrappers.

reivilibre and others added 2 commits February 24, 2022 11:58
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
@reivilibre reivilibre requested a review from clokep February 24, 2022 16:45
@reivilibre
Copy link
Contributor Author

@clokep I've now bundled the changes to the tests in this PR, as suggested.

@reivilibre
Copy link
Contributor Author

I guess it isn't doable to use the same class directly?

I did this originally, but got told to do it this way. I think this way is cleaner even if just because the callbacks need their signatures massaging through the wrappers.

(I think we will eventually want to cut out the 'old way'; at that point it would be sensible to remove the wrapper.)

@clokep
Copy link
Member

clokep commented Feb 24, 2022

(I think we will eventually want to cut out the 'old way'; at that point it would be sensible to remove the wrapper.)

But we would have to ask people to update their Synapse config again though, which is really not ideal. This is why I was asking!

@reivilibre
Copy link
Contributor Author

(I think we will eventually want to cut out the 'old way'; at that point it would be sensible to remove the wrapper.)

But we would have to ask people to update their Synapse config again though, which is really not ideal. This is why I was asking!

I think we would just stick with the name with 'Module' on the end; we do that for some other modules so it wouldn't be that much out of place

@reivilibre reivilibre merged commit 58a6986 into main Feb 25, 2022
@reivilibre reivilibre deleted the rei/sma_wrapper branch February 25, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port the module to Synapse's pluggable modules
2 participants