-
Notifications
You must be signed in to change notification settings - Fork 46
Add a wrapper so that the module can be used with the new module API #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b050d7b
to
65cb558
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK. I think it would make sense to include the tests in this PR.
I guess it isn't doable to use the same class directly? Since the class itself doesn't know how it is registered?
I did this originally, but got told to do it this way. I think this way is cleaner even if just because the callbacks need their signatures massaging through the wrappers. |
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
@clokep I've now bundled the changes to the tests in this PR, as suggested. |
(I think we will eventually want to cut out the 'old way'; at that point it would be sensible to remove the wrapper.) |
But we would have to ask people to update their Synapse config again though, which is really not ideal. This is why I was asking! |
I think we would just stick with the name with 'Module' on the end; we do that for some other modules so it wouldn't be that much out of place |
Fixes #133
Alternative to #134.