Break out non-JSON request/response content types as tables #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we display this as a table like "image/png|image/jpeg" and description on a single line, but we're using a table. This breaks the join out to individual rows.
This was referenced Mar 19, 2024
anoadragon453
approved these changes
Mar 21, 2024
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
I don't visually see a difference for /client-server-api/#post_matrixmediav3upload, but /client-server-api/#get_matrixmediav3thumbnailservernamemediaid is a marked improvement.
Thank you!
Member
Author
|
hmm, good point on |
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we display this as a table like "image/png|image/jpeg" and description on a single line, but we're using a table. This breaks the join out to individual rows.
See
/client-server-api/#get_matrixmediav3thumbnailservernamemediaidand/client-server-api/#post_matrixmediav3uploadfor examples.Preview: https://pr1756--matrix-spec-previews.netlify.app