Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec for MSC2746 #1511
Add spec for MSC2746 #1511
Changes from 21 commits
4b1b6dd
ef15055
0a8362f
e49a85c
2abbc64
774968b
93dd4e5
b75850f
d8dd3e0
ebed260
efdb1ec
f4b6c62
d9bd32d
78719b4
ecb3070
2801c6f
6a058d0
e741e3a
a7f5b8f
c079875
af22989
1fda1ec
a6c2cf2
ea3cbec
70d7c36
5b8e3ef
1023399
ea056a7
1855205
25ea0df
5d53d67
ffa0a6f
a5c9911
d1b4c72
163605c
c6ae1a4
d230788
492d052
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of weird to have the bullet point start in the middle of the parenthetical. Also, I'm failing to parse what the "current" at the end of the previous line is supposed to mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mm, yes, fairly sure this didn't come out as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be worthwhile to factor out the
call_id
,version
, andparty_id
fields into a file that could be included in all the voip events. Maybe acore-event-schema/voip_event.yaml
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is neater. The only downside is that it repeats all the fields from a room event and I'm not sure how to make it not do that.