Fix up description of knock_room_state field, which implied the required field was optional
#1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
changed the title
knock_room_state field, which implied the required field was optionalknock_room_state field, which implied the required field was optional
turt2live
approved these changes
Oct 6, 2022
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
…uired field was optional (matrix-org#1276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC2403 states that this field is required. I'm not sure I actually agree with that, but it's what the MSC says.
Before this PR, the description of this field looked like:
This PR drops the optional part:
Preview: https://pr1276--matrix-spec-previews.netlify.app